{{ message }}
Repository navigation
Fix metadata compatibility for mixed Dubbo and Triple protocols - #16525
Open
hehuang139 wants to merge 2 commits into
Open
hehuang139 wants to merge 2 commits into
hehuang139 wants to merge 2 commits into
Conversation
4 tasks done
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of the change?
Fixes #15641.
With local metadata and both
dubboandtriprotocols, MetadataService V1 can be exported over Dubbo while the advertised URL points to the Triple V2 endpoint. A Dubbo 3.1.11 consumer then calls the V1 interface on that endpoint and fails withUNIMPLEMENTED: Invoker for gRPC not found, even withonly-use-metadata-v2=false.Export both metadata versions over Triple when V2 is enabled and advertise the V1 URL parameters for compatibility. Keep the V2 capability marker so current consumers still negotiate V2. Honor an explicit metadata protocol from either the application property or its parameters map when deciding whether to enable V2. The RPC tests allocate available protocol ports to avoid the cached default port colliding with other tests.
Validation on Linux with Maven 3.9.9:
50051; the revised test passed with that port occupied.spotless:checkfor both changed modules andgit diff --check.Test commands (after installing reactor dependencies, with
JAVA_HOMEandPATHset to the indicated JDK):Checklist