{{ message }}
Repository navigation
Fix metadata retries blocking provider instance updates - #16522
Open
hehuang139 wants to merge 2 commits into
Open
hehuang139 wants to merge 2 commits into
hehuang139 wants to merge 2 commits into
Conversation
5 tasks done
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of the change?
Fixes #16149.
A metadata retry holds the instance listener monitor while fetching metadata from providers. If that request stalls, registry callbacks cannot update the provider list and subsequent retries continue using obsolete instances.
Update instance lists under a short synchronized section and let one refresh processor retrieve metadata from a snapshot. Notifications received during retrieval update the latest snapshot and return; obsolete results are discarded before address publication. Pending changes are also processed after a retrieval failure. Destroyed listeners reject late results and release queued instance events, including when destruction races with the next refresh iteration.
Validation on Linux with JDK 17 and Maven 3.9.9:
spotless:checkandgit diff --check.The test command was:
mvn -B -ntp -pl dubbo-registry/dubbo-registry-api -am test jacoco:report -Dtest=ServiceInstancesChangedListenerConcurrencyTest,ServiceInstancesChangedListenerTest,ServiceInstancesChangedListenerWithoutEmptyProtectTest,ServiceDiscoveryRegistryTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -Pjacoco,skip-spotless -Dcheckstyle.skip=true -Drat.skip=trueChecklist