DRILL-8180: Add Icons to Storage Plugin List by cgivre · Pull Request #2507 · apache/drill · GitHub
Skip to content

DRILL-8180: Add Icons to Storage Plugin List - #2507

Open
cgivre wants to merge 3 commits into
apache:masterfrom
cgivre:storage_icons
Open

DRILL-8180: Add Icons to Storage Plugin List#2507
cgivre wants to merge 3 commits into
apache:masterfrom
cgivre:storage_icons

Conversation

@cgivre

@cgivre cgivre commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

DRILL-8180: Add Icons to Storage Plugin List

Description

Documentation

This PR adds icons to the storage plugin list depending on the type of storage plugin. See screenshot below.

Screen Shot 2022-03-28 at 3 56 36 PM

The logo gets its name from the plugin config file. So a plugin FooStoragePluginConfig would be required to provide an icon of approx 40px x 40px called Foo.png.

Testing

Tested manually

@cgivre cgivre added the enhancement PRs that add a new functionality to Drill label Mar 28, 2022
@cgivre cgivre self-assigned this Mar 28, 2022
@jnturton
jnturton requested a review from pjfanning March 29, 2022 08:57
@jnturton

jnturton commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

@cgivre

cgivre commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.

I would really appreciate that. I don't actually have image editing software on my machine, or experience with the GIMP. Also, if you don't like any of the icons, feel free to change.

vvysotskyi
vvysotskyi requested changes Mar 29, 2022
View reviewed changes

@vvysotskyi vvysotskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?

@cgivre

cgivre commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?

I suppose so, but I'm not quite sure how you would do that. All the Drill REST server components (to include static resources) are contained in java-exec. Any ideas?

@vvysotskyi

vvysotskyi commented Mar 29, 2022

Copy link
Copy Markdown
Member

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvysotskyi vvysotskyi vvysotskyi requested changes
@pjfanning pjfanning Awaiting requested review from pjfanning

Requested changes must be addressed to merge this pull request.

Assignees

@cgivre cgivre

Labels

enhancement PRs that add a new functionality to Drill

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cgivre @jnturton @vvysotskyi