{{ message }}
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5831; builds on the fixes in #5828.
Rationale for this change
A new constructor field can be omitted from a native operator's handwritten
equals, allowing exchange reuse between different plans. A structural guard makes each omission require an explicit decision.What changes are included in this PR?
Discover native plan classes and check constructor parameters against reads in
equalsor documented exclusions. Add a negative fixture and register the suite in Linux and macOS CI.CometBroadcastExchangeExec.modeis explicitly excluded because Comet broadcasts mode-independent Arrow batches. This preserves its current reuse behavior; the guard checks field coverage rather than proving equality semantics.How are these changes tested?
Both
CometPlanEqualitySuitetests pass in the local verification run on Spark 4.1.3 / JDK 21 after rebasing onto main. Formatting and Scalastyle passed. Cross-version fork CI passed before rebasing. The PR contains only the guard and CI registration; #5828's production fixes are already on main.