{{ message }}
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4616.
Rationale for this change
The existing
array_intersectfixtures compare results without asserting the selected implementation or covering a disabled dispatcher.What changes are included in this PR?
Exercise all four combinations of native opt-in and codegen dispatch in the existing fixture. Assert native, dispatched and fallback paths. Include a longer right-hand array to check Spark's left-input ordering on compatible paths, and normalize the permitted order difference for native opt-in.
How are these changes tested?
The updated
array_intersect.sqlfixture passes throughCometSqlFileTestSuiteon Spark 4.1.3 / JDK 21 after rebasing onto main. Formatting and Scalastyle passed. The earlier fork CI failure was a macOShdfsThreadDestructorcrash; this base includes #5892, which removes the triggering HDFS suite from CI.