{{ message }}
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No linked issue; this adds coverage for binary inputs to
crc32.Rationale for this change
The existing
crc32tests use strings or values cast to strings, so they do not exercise arbitrary binary input such as invalid UTF-8 or embedded zero bytes.What changes are included in this PR?
Extend the SQL fixture with binary columns and literals covering invalid UTF-8, embedded zero bytes, multibyte UTF-8, empty input, NULL, and a checksum above the signed 32-bit range. Compare results with Spark and require Comet execution.
How are these changes tested?
The
crc32.sqlfixture passes locally throughCometSqlFileTestSuiteon Spark 3.5.9 and 4.1.3 with JDK 17. All four queries compare results with Spark and require Comet execution.make format(Spark 3.5) and Apache RAT passed.