{{ message }}
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No linked issue; this adds test coverage for the existing SQL fixture parser.
Rationale for this change
The parser tests cover query assertion modes but do not directly check the configuration and version metadata that control fixture execution, or the statement records and table names used for diagnostics and cleanup.
What changes are included in this PR?
Add four tests for empty/comment-only fixtures, configuration ordering and whitespace, independent Spark version bounds, and mixed statement/query records. Check multiline SQL, source line numbers, table extraction, and the final record with and without a trailing blank line.
How are these changes tested?
All 12 tests in
SqlFileTestParserSuitepass locally on Spark 3.5.9 and 4.1.3 with JDK 17, including the four new tests.make format(Spark 3.5) and Apache RAT passed.