{{ message }}
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4616.
Rationale for this change
The
json_array_lengthfixtures compare results but do not distinguish native execution from JVM codegen dispatch. They also omit fallback coverage when the dispatcher is disabled.What changes are included in this PR?
Add a routing test covering native opt-in and dispatcher settings, column and literal arguments, NULL, empty arrays, and lenient JSON parsing on the default path. Compare results with Spark and check fallback reasons or the native projection's expression payload. Inspecting the payload also covers Spark 4's
StaticInvokerewrite, which does not preserve the expression's implementation tags.How are these changes tested?
The targeted
CometCodegenSuitetest and both existingjson_array_lengthSQL fixtures pass locally on Spark 3.5.9 and 4.1.3 with JDK 17. The new test covers 12 query/configuration combinations.make format(Spark 3.5) and Apache RAT passed.