{{ message }}
fix swapped constant maps in Form.process for extended forms#413
Open
sahvx655-wq wants to merge 1 commit into
Open
fix swapped constant maps in Form.process for extended forms#413sahvx655-wq wants to merge 1 commit into
sahvx655-wq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I was reading through the form-extension path and noticed
Form.processcalls itself with the first two arguments in a different order to the method's own signature and to the other two call sites, which is what put me onto this.Form.processrecurses into the inherited form at Form.java:224 asparent.process(constants, globalConstants, forms), so the global map and the form-set map are swapped relative to the declaredprocess(globalConstants, constants, forms).Field.processapplies the form-set constants first and the global constants second, so for a shared constant name the form-set value is meant to win; because of the swap a parent form reached throughextendsresolves that constant to the global value instead, the opposite precedence to a non-extended form and to the correct calls at Form.java:240 and FormSet.java:312.ExtensionTestthat extends a base form sharing a constant name with a global one and asserts the form-set value wins; it fails before this change (expected: <formset> but was: <global>) and passes after.Left unfixed, any form that uses
extendstogether with a form-set constant overriding a like-named global constant silently picks up the wrong value, and which value wins also depends on the form iteration order, so it is not deterministic across runs.Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.