Fix 2FA becoming enabled when the user inputs the wrong code during setup by winterhazel · Pull Request #7972 · apache/cloudstack · GitHub
Skip to content

Fix 2FA becoming enabled when the user inputs the wrong code during setup#7972

Merged
DaanHoogland merged 1 commit into
apache:4.18from
scclouds:fix-2fa-setup-verification
Sep 26, 2023
Merged

Fix 2FA becoming enabled when the user inputs the wrong code during setup#7972
DaanHoogland merged 1 commit into
apache:4.18from
scclouds:fix-2fa-setup-verification

Conversation

@winterhazel

@winterhazel winterhazel commented Sep 18, 2023

Copy link
Copy Markdown
Member

Description

During the 2FA setup, the user must input a code in order to verify the configuration. If the user inserts the wrong code, an error message is shown; however, 2FA still gets enabled.

This PR fixes this behavior and prevents 2FA from becoming enabled if the user inserts the wrong code.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

In a local lab:

  • In a user of the root admin account, I opened the 2FA setup, selected static PIN, provided the wrong PIN and verified that 2FA did not get enabled;
  • In a user of the root admin account, I opened the 2FA setup, selected static PIN, provided the correct PIN and verified that 2FA was enabled;
  • In a user of a non-admin account belonging to domain test/test2, I opened the 2FA setup, selected static PIN, provided the wrong PIN and verified that 2FA did not get enabled.
  • In a user of a non-admin account belonging to domain test/test2, I opened the 2FA setup, selected static PIN, provided the correct PIN and verified that 2FA was enabled.

@codecov

codecov Bot commented Sep 19, 2023

Copy link
Copy Markdown

@DaanHoogland

DaanHoogland commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Sep 19, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Sep 19, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7059

@DaanHoogland

DaanHoogland commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Sep 19, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Sep 19, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7691)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7972-t7691-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_destroy_ssvm Failure 910.80 test_ssvm.py

shwstppr
shwstppr approved these changes Sep 20, 2023
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@yadvr yadvr added this to the 4.18.2.0 milestone Sep 23, 2023
@yadvr

yadvr commented Sep 25, 2023

Copy link
Copy Markdown
Member

ping @harikrishna-patnala can you review this?

harikrishna-patnala
harikrishna-patnala approved these changes Sep 26, 2023
View reviewed changes

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, code LGTM

@harikrishna-patnala

harikrishna-patnala commented Sep 26, 2023

Copy link
Copy Markdown
Member

reproduced the issue and verified the fix, it is looking good. Thanks @rohityadavcloud

@DaanHoogland DaanHoogland merged commit ef74221 into apache:4.18 Sep 26, 2023
@GutoVeronezi

GutoVeronezi commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Oct 12, 2023
@winterhazel @yadvr
Fix 2FA becoming enabled when the user inputs the wrong code during s…
4f86c45 
…etup (apache#7972)

(cherry picked from commit ef74221)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request Mar 31, 2024
@winterhazel @yadvr
Fix 2FA becoming enabled when the user inputs the wrong code during s…
0bf2711 
…etup (apache#7972)

(cherry picked from commit ef74221)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@harikrishna-patnala harikrishna-patnala mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes
@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

Assignees

No one assigned

Labels

type:security

Projects

None yet

Milestone

4.18.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@winterhazel @DaanHoogland @blueorangutan @yadvr @harikrishna-patnala @GutoVeronezi @shwstppr