CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type by jayapalu · Pull Request #2128 · apache/cloudstack · GitHub
Skip to content

CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type#2128

Closed
jayapalu wants to merge 1 commit into
masterfrom
unknown repository
Closed

CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type#2128
jayapalu wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@jayapalu

@jayapalu jayapalu commented May 25, 2017

Copy link
Copy Markdown
Contributor

Updated the traffic_type to PrivateGw to avoid configuring keepalied on the private gateway interface.
For more details about the bug please see CLOUDSTACK-9885

@cloudmonger

cloudmonger commented May 29, 2017

Copy link
Copy Markdown

@yadvr

yadvr commented Nov 30, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 30, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 30, 2017

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1329

@yadvr

yadvr commented Dec 1, 2017

Copy link
Copy Markdown
Member

@jayapalu please fix the conflicts and build failures

@yadvr

yadvr commented Dec 11, 2017

Copy link
Copy Markdown
Member

@jayapalu can you fix conflicts and move sql related changes to appropriate 4.10->4.11 path?

@yadvr yadvr added this to the 4.11 milestone Dec 19, 2017
@yadvr

yadvr commented Dec 19, 2017

Copy link
Copy Markdown
Member

@jayapalu this is marked as a blocker, can you help fix this? Thanks.

@yadvr

yadvr commented Dec 22, 2017

Copy link
Copy Markdown
Member

Ping @jayapalu can you please respond? This issue is marked as blocker in jira. /cc @karuturi @sateesh-chodapuneedi @priyankparihar @yvsubhash and others at Accelerite who may want to work with the community on this?

@yadvr

yadvr commented Jan 2, 2018

Copy link
Copy Markdown
Member

ping @jayapalu

I'll remove this from 4.11 milestone due to lack of engagement, response from the author and discussions.

@yadvr yadvr modified the milestone: 4.11 Jan 2, 2018
@jayapalu @yadvr
CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type
6161602 
Updated the traffic_type to PrivateGw to avoid configuring keepalied on
the private gateway interface.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
yadvr reviewed Jan 7, 2018
View reviewed changes
Comment thread server/src/com/cloud/network/guru/PrivateNetworkGuru.java
EntityManager _entityMgr;

private static final TrafficType[] TrafficTypes = {TrafficType.Guest};
private static final TrafficType[] TrafficTypes = {TrafficType.PrivateGw};

@yadvr yadvr Jan 7, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause regression @jayapalu ? /cc @ustcweizhou

@yadvr

yadvr commented Jan 7, 2018

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Jan 7, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 7, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1612

@yadvr

yadvr commented Jan 7, 2018

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Jan 7, 2018

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jan 8, 2018

Copy link
Copy Markdown

Trillian test result (tid-2068)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29768 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2128-t2068-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_vpc_privategw_acl Failure 41.03 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 101.85 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 111.95 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 157.04 test_privategw_acl.py
test_02_attach_volume Failure 669.80 test_volumes.py
test_07_resize_fail Failure 15.23 test_volumes.py

@yadvr

yadvr commented Jan 8, 2018

Copy link
Copy Markdown
Member

@jayapalu can you address outstanding questions and look at failures?
@ustcweizhou since you've had fixed the issue in a different way, can you help review the PR? Thanks.

@yadvr

yadvr commented Jan 9, 2018

Copy link
Copy Markdown
Member

Given there is no engagement from the author and this issue is a specific case, does not block the release I'll move this to 4.12 milestone. /cc @jayapalu

@yadvr yadvr modified the milestones: 4.11, 4.12 Jan 9, 2018
@yadvr yadvr mentioned this pull request Jun 21, 2018
Closed
@yadvr

yadvr commented Oct 8, 2018

Copy link
Copy Markdown
Member

Essentially, the private gateway from a user point of view is still a kind guest network type providing access for guest VMs. I started by extending/fixing this PR but found it to be not necessary to add a new traffic type to fix this which will also require codebase-wide refactoring and additional checks wherever TrafficType.Guest is used throughout the codebase.

In #2888 the VR nics are aggregated and programmed by the nic device order and in the VR the ip_association is handled such that the device order is found by referencing the mac address for an ipaddress than the device id from the json. /cc @PaulAngus

I'm still able to reproduce the issue https://issues.apache.org/jira/browse/CLOUDSTACK-9885 in case of rVRs but I think it's solvable by adding a new boolean to say whether a guest network nic is a private gateway and handle that case in VR.

@rafaelweingartner rafaelweingartner removed this from the 4.12.0.0 milestone Jan 9, 2019
@richardlawley richardlawley mentioned this pull request Jun 12, 2019
Closed
@yadvr yadvr added this to the 4.14.0.0 milestone Jun 20, 2019
@andrijapanicsb

andrijapanicsb commented Jan 4, 2020

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr left review comments

Assignees

No one assigned

Labels

type:bug

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jayapalu @cloudmonger @yadvr @blueorangutan @andrijapanicsb @rafaelweingartner