veeam-control-service: fix vm pagination by shwstppr · Pull Request #13383 · apache/cloudstack · GitHub
Skip to content

veeam-control-service: fix vm pagination#13383

Open
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:fix-vcs-pagination
Open

veeam-control-service: fix vm pagination#13383
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:fix-vcs-pagination

Conversation

@shwstppr

@shwstppr shwstppr commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Currently, Veeam doesn't not support pagination for the UHAPI calls but for future support this change would allow listing resources with pagination correctly.
Only consider page in pagination for search clause https://ovirt.github.io/ovirt-engine-api-model/4.5/#_pagination

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
veeam-control-service: fix vm pagination
859da50 
Only consider page in pagination for search clause
https://ovirt.github.io/ovirt-engine-api-model/4.5/#_pagination

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecov Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

@winterhazel winterhazel added this to the 4.24.0 milestone Jun 10, 2026
@winterhazel

winterhazel commented Jun 10, 2026

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Jun 10, 2026

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 10, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18220

@shwstppr

shwstppr commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@winterhazel can this be included in the 4.23.0 milestone, or are we not accepting items for 4.23?
I'm changing the milestone for now

@shwstppr shwstppr modified the milestones: 4.24.0, 4.23.0 Jun 11, 2026
@winterhazel

winterhazel commented Jun 11, 2026

Copy link
Copy Markdown
Member

@winterhazel can this be included in the 4.23.0 milestone, or are we not accepting items for 4.23? I'm changing the milestone for now

@shwstppr yes, I originally intended to include this in 4.23, but probably missclicked. Thanks for noticing and moving it to the correct milestone.

nvazquez
nvazquez approved these changes Jun 11, 2026
View reviewed changes

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@github-actions github-actions Bot mentioned this pull request Jun 11, 2026
Closed
@shwstppr

shwstppr commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 12, 2026

Copy link
Copy Markdown

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jun 12, 2026

Copy link
Copy Markdown

[SF] Trillian test result (tid-16296)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53173 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13383-t16296-kvm-ol8.zip
Smoke tests completed. 149 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_08_upgrade_kubernetes_ha_cluster Failure 682.12 test_kubernetes_clusters.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes
@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

status:needs-review status:needs-testing

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @winterhazel @blueorangutan @nvazquez