ui: do not show deploy instance button for not ready images by shwstppr · Pull Request #13161 · apache/cloudstack · GitHub
Skip to content

ui: do not show deploy instance button for not ready images#13161

Merged
winterhazel merged 3 commits into
apache:4.22from
shapeblue:ui-depltmpl-notreadytmpl
Jun 11, 2026
Merged

ui: do not show deploy instance button for not ready images#13161
winterhazel merged 3 commits into
apache:4.22from
shapeblue:ui-depltmpl-notreadytmpl

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Currently, InfoCard for a not ready template shows deploy instance button which is incorrect.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Currently, InfoCard for a not ready template shows deploy instance
button which is incorrect.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@winterhazel winterhazel added this to the 4.22.2 milestone May 15, 2026
@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread ui/src/components/view/ImageDeployInstanceButton.vue
Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Outdated
Comment thread ui/src/components/view/ImageDeployInstanceButton.vue
@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13161 (QA-JID-928)

Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Outdated
Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Outdated
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread ui/src/components/view/ImageDeployInstanceButton.vue Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, no testing yet

@winterhazel winterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked in a local environment that the deploy button is, in fact, not shown for templates/ISOs that are not ready anymore.

@winterhazel winterhazel merged commit 8e933b7 into apache:4.22 Jun 11, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants