{{ message }}
Handle "log gone" (PYTHON-1266) at the end of _run_loop#1133
Merged
Conversation
If log is somehow gone and file exception due to the race mention in PYTHON-1266 it will also inevitably fail for the same reason after the loop so we need to catch the exception there as well.
tlasica
changed the title
tlasica
changed the title
tlasica
changed the title
absurdfarce
reviewed
Jan 5, 2023
Contributor
There was a problem hiding this comment.
Given that this verbiage is already used for the existing logging try/catch in this method we're starting to get into some ugly duplication here. Prolly worth pulling this out into a function, something like:
def maybe_log_debug(*args, **kwargs)
try:
log.debug(*args, **kwargs)
except Exception:
# TODO: Remove when Python 2 support is removed
# PYTHON-1266. If our logger has disappeared, there's nothing we
# can do, so just log nothing.
passand then call with appropriate params.
This is a relatively minor thing so I can prolly also just clean it up after this gets merged if you don't wanna muck with it @tlasica. Either way is good with me!
Contributor
Author
There was a problem hiding this comment.
I was thinking about it, but I decided not to do it:
- there are 2 occurences, my rule of thumb is 3
- all are local in the same function
TLDR I think it is not worth it.
Contributor
There was a problem hiding this comment.
No worries, I can take care of it. Thanks for the fix @tlasica!
|
Perhaps it is prudent to gateway language version sensitive areas of the code using the factory pattern. This would save adding many if and try statements downstream. |
Contributor
Lorak-mmk
added a commit
to Lorak-mmk/python-driver
that referenced
this pull request
Mar 31, 2023
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (apache#1112) Merge pull request apache#1140 from python-driver/python-1327 Merge pull request apache#1139 from python-driver/python-1328 Merge pull request apache#1137 from python-driver/python-1329 Merge pull request apache#1128 from python-driver/python-1304 Fix jenkins builds (apache#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (apache#1133) HostFilterPolicyInitTest fix for Python 3.11 (apache#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
Lorak-mmk
added a commit
to Lorak-mmk/python-driver
that referenced
this pull request
Apr 12, 2023
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (apache#1112) Merge pull request apache#1140 from python-driver/python-1327 Merge pull request apache#1139 from python-driver/python-1328 Merge pull request apache#1137 from python-driver/python-1329 Merge pull request apache#1128 from python-driver/python-1304 Fix jenkins builds (apache#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (apache#1133) HostFilterPolicyInitTest fix for Python 3.11 (apache#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If log is somehow gone and file exception due to the race mention in PYTHON-1266 it will also inevitably fail for the same reason after the loop so we need to catch the exception there as well.
I have hit it in some Cassandra dtest: