{{ message }}
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The numeric check still accepts overlong values containing leading zeros, contrary to the stated eight-digit limit.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents overflow when parsing oversized gRPC timeout headers.
Changes:
- Bounds parsed timeout values before unit conversion.
- Adds regression and boundary tests.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertGrpcTimeoutToUS parses the grpc-timeout header from any gRPC client but only checks that a single unit char trails the digits, so a value with many digits (or a negative one) flows into timeout_value * and overflows int64, which is undefined and then lands a bogus deadline in gettimeofday_us() on the request path. The gRPC-over-HTTP2 spec caps TimeoutValue at an 8-digit positive integer, so reject anything outside 0..99999999 before the multiply. The added regression test decodes a 999999999999999999H timeout, which returns a wrapped value today and -1 after the change.