{{ message }}
Improve handling of partial reads and EOF in Frame size limited filter#2154
Merged
Merged
Conversation
This update makes the following changes/improvements: * If the wrapped stream is finished and returns -1 this is now returned correctly and availableBytes are not decremented. * Partial reads now will be attempted up to the availableBytes limit * If 0 is passed in for the length for a partial read then no attempt to read is done and 0 is returned, in line with the spec.
tabish121
approved these changes
Jun 23, 2026
tabish121
left a comment
tabish121
left a comment
Contributor
There was a problem hiding this comment.
Changes seems reasonable for getting this a bit more aligned with a standard stream type
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
that referenced
this pull request
Jun 24, 2026
#2154) (#2156) This update makes the following changes/improvements: * If the wrapped stream is finished and returns -1 this is now returned correctly and availableBytes are not decremented. * Partial reads now will be attempted up to the availableBytes limit * If 0 is passed in for the length for a partial read then no attempt to read is done and 0 is returned, in line with the spec. (cherry picked from commit 5d9c303)
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Jun 24, 2026
apache#2154) This update makes the following changes/improvements: * If the wrapped stream is finished and returns -1 this is now returned correctly and availableBytes are not decremented. * Partial reads now will be attempted up to the availableBytes limit * If 0 is passed in for the length for a partial read then no attempt to read is done and 0 is returned, in line with the spec. (cherry picked from commit 5d9c303)
cshannon
added a commit
that referenced
this pull request
Jun 24, 2026
#2154) (#2155) This update makes the following changes/improvements: * If the wrapped stream is finished and returns -1 this is now returned correctly and availableBytes are not decremented. * Partial reads now will be attempted up to the availableBytes limit * If 0 is passed in for the length for a partial read then no attempt to read is done and 0 is returned, in line with the spec. (cherry picked from commit 5d9c303)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes the following changes/improvements: