{{ message }}
Disable the message servlet by default#2000
Merged
Merged
Conversation
Contributor
cshannon
force-pushed
the
disable-message-servlet
branch
from
ad8ac87 to
15d8d60
Compare
jbonofre
previously approved these changes
May 11, 2026
|
|
||
| <display-name>Apache ActiveMQ REST API</display-name> | ||
|
|
||
| <servlet> |
Member
There was a problem hiding this comment.
Maybe worth to keep in the file, but commented, just in case the user absolutely wants to use it.
Contributor
Author
There was a problem hiding this comment.
I originally just commented it out but then removed it entirely (it's still the demo project). I can go either way though. @mattrpav what do you think?
Contributor
Author
There was a problem hiding this comment.
This was my original commit before force pushing: ad8ac87
Contributor
There was a problem hiding this comment.
I'm good with comment it out as a good step here. It'll surface questions from users needing to reanble it and we'll get a sense of how it is used.
Going forward (v7) there is probably a modernization task for this.
Contributor
cshannon
force-pushed
the
disable-message-servlet
branch
from
15d8d60 to
ad8ac87
Compare
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
that referenced
this pull request
May 13, 2026
cshannon
added a commit
that referenced
this pull request
May 13, 2026
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2015) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit d82f61f)
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2015) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit d82f61f)
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2015) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit d82f61f)
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2014) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit 8b5af8d)
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2015) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit d82f61f)
cesarhernandezgt
pushed a commit
to tomitribe/activemq
that referenced
this pull request
Jun 16, 2026
…pache#2014) * Disable the message servlet by default * Add warning message and deprecated annotation (cherry picked from commit d8a8540) (cherry picked from commit 8b5af8d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The servlet will still be enabled by default in the web demo project
Edit: I marked the servlet as deprecated and also added comments about why