ci: fix deploy failed when get empty pr id by zombieJ · Pull Request #50001 · ant-design/ant-design · GitHub
Skip to content

ci: fix deploy failed when get empty pr id#50001

Merged
zombieJ merged 1 commit into
masterfrom
fix-ci
Jul 22, 2024
Merged

ci: fix deploy failed when get empty pr id#50001
zombieJ merged 1 commit into
masterfrom
fix-ci

Conversation

@zombieJ

@zombieJ zombieJ commented Jul 22, 2024

Copy link
Copy Markdown
Member

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Sometime action write empty pr id in file which will deploy wrong url preview. Fail first if pr id not valid.

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: https://ant.design/changelog
Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions

github-actions Bot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Preview is ready

@github-actions

github-actions Bot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

👁 Visual Regression Report for PR #50001 Passed ✅

🎯 Target branch: master (2194603)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 342 KB
./dist/antd-with-locales.min.js 392.49 KB

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2024

Copy link
Copy Markdown

commit: 23ad202

antd

npm i https://pkg.pr.new/ant-design/ant-design/antd@50001


templates

@codecov

codecov Bot commented Jul 22, 2024

Copy link
Copy Markdown

@zombieJ zombieJ merged commit 29490fa into master Jul 22, 2024
@zombieJ zombieJ deleted the fix-ci branch July 22, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants