{{ message }}
Repository navigation
feat(app): hydrate user attachments on demand - #57729
Open
kitlangton wants to merge 6 commits into
Open
kitlangton wants to merge 6 commits into
kitlangton wants to merge 6 commits into
Conversation
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changed
Timeline pages opt into
attachments=reference; every general API call keeps inline bytes by default. Inline user files become stable per-message references, with originals loaded near the image viewport or on a file click. Single-message reads and model context retain originals.Review fixes:
#56989 is now stacked on this PR and extends the same query parameter to read-tool inline files. Execute screenshots remain inline pending a hydration path. Merge this parent first, then retarget #56989 to beta.
Measurements
Reused HOME-shaped numeric fixture, with explicitly synthetic user-attachment placement. One warmup plus seven alternating-mode measurements on Pro through HiveMind:
Verification