{{ message }}
Repository navigation
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good. I couldn't check it with a real deploy (the 412 only shows up on a Cloudflare upload and there are no credentials here), so I reviewed the diff against #57548. It removes exactly the migration block that change added. The Api worker no longer has a SyncServer binding or class anywhere, so it needs no migration, and an upload with no migrations leaves the existing v2 tag alone. The public API is unchanged (infra config only). The only leftover is the one you mention: a personal stage that never deployed #57548 will keep its SyncServer class until it gets that migration once. That's dev-only and doesn't block the merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
#57548 added a one-time Durable Object migration to the Api worker (
undefined/v1→v2, deleteSyncServer). That migration was applied on the last dev and production deploys, so both scripts are already at tagv2. Every upload of the Api worker now fails with a 412:The first change to
packages/function/src/api.tssince then was #57630, so that's when it showed up. Failed runs:Until this is fixed, every dev deploy will fail because the Api worker has a pending update.
This removes the migration that's already applied. With no migrations sent, Cloudflare keeps the script at
v2. That's how wrangler behaves when there are no pending migrations. The worker has no Durable Object bindings, so nothing else needs a migration. Personal stages that never deployed #57548 would still need it once. Those stages are dev-only.How did you verify your code works?
v2Screenshots / recordings
N/A
Checklist