{{ message }}
Repository navigation
Conversation
Contributor
3 of 6 tasks
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
OpeOginni
force-pushed
the
folder-access-errors
branch
from
October 3, 2026 18:01
bb76bf3 to
fc36bf8
Compare
Contributor
OpeOginni
force-pushed
the
folder-access-errors
branch
from
October 4, 2026 21:26
fc36bf8 to
fc0b100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue for this PR
Fixes the permission-denied server errors in #50951.
Type of change
What does this PR do?
Focuses only on reporting permission errors during Location boot. Builds on #52649 and #52668, which already classify filesystem permission failures and return 404 for missing Location folders.
FileSystem.DirectoryAccessDeniedErrortyped throughInstance.layerinstead of turning it into a defect and returning 500.EACCESand macOS privacy denials reported asEPERM; unrelated failures remain defects.LocationPermissionDeniedError(403) through the existing Location error mappings, with the corresponding Protocol and generated client declarations.No new filesystem checks are added.
location.get, filesystem boot canonicalization, and the Workerd filesystem replacement matchv2. Cached Locations are not rechecked when their folders become inaccessible after boot. Missing-folder behavior and desktop UI are unchanged.How did you verify your code works?
bun run checkfrom the repository root.packages/server/test/fetch.test.tsverifies that a denied parent folder returns 403 for model and Location requests, recovers after access is restored, and does not recheck cached access after permissions are revoked again.bun run generate.Checklist