{{ message }}
Repository navigation
fix(tui): read text from clipboard directly on Windows (#13800) - #48611
Closed
Mushfiqtaief wants to merge 1 commit into
Closed
Mushfiqtaief wants to merge 1 commit into
Mushfiqtaief wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13800
Type of change
What does this PR do?
On Windows 11, pressing
Ctrl+Vor clicking clipboard history (Win+V) in the TUI prompt fails to paste text.In
packages/tui/src/clipboard.ts, the Windows implementation only checks for images with PowerShell and then falls through toclipboardy.read()for text. In compiled standalone binaries,clipboardyfails or is blocked by execution policy, causing clipboard reading to silently returnundefined.This PR updates the Windows/WSL
read()implementation inpackages/tui/src/clipboard.tsto use PowerShell's built-inGet-Clipboardcmdlet:Get-Clipboard -Rawand outputs directly as UTF-8.Get-Clipboard -Format Imageif no text is present to handle images as base64 PNG.[Console]::Out.Writeto stream output without appending extraneous trailing newlines.How did you verify your code works?
Tested locally on Windows 11 in Windows Terminal, PowerShell, and cmd.exe:
Ctrl+VCtrl+VScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
N/A (TUI clipboard behavior fix)
Checklist