refactor(core): move more tests to nodes by jlongster · Pull Request #34248 · anomalyco/opencode · GitHub
Skip to content

refactor(core): move more tests to nodes#34248

Merged
jlongster merged 1 commit into
devfrom
jlongster/more-tests2
Jun 27, 2026
Merged

refactor(core): move more tests to nodes#34248
jlongster merged 1 commit into
devfrom
jlongster/more-tests2

Conversation

@jlongster

Copy link
Copy Markdown
Contributor

Issue for this PR

N/A

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Moves ten more core tests from manual defaultLayer composition to the node graph system.

  • Uses LayerNode.compile(...) for direct global service test environments.
  • Uses AppNodeBuilder.build(...) for app/location-scoped graphs.
  • Keeps directly-yielded transitive services as explicit graph roots.
  • Binds synthetic Location.node implementations in location-focused tests instead of composing ad hoc default layers.
  • Uses LayerNode.replace(...) for test-specific layer overrides.

How did you verify your code works?

  • bun test "test/ripgrep.test.ts" "test/filesystem/search.test.ts" "test/git.test.ts" "test/effect/cross-spawn-spawner.test.ts" "test/integration.test.ts" "test/location-filesystem.test.ts" "test/location-mutation.test.ts" "test/skill.test.ts" "test/plugin/skill.test.ts" "test/system-context/builtins.test.ts" in packages/core
  • bun typecheck in packages/core
  • Pre-push bun turbo typecheck

Screenshots / recordings

N/A - no UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@jlongster jlongster enabled auto-merge (squash) June 27, 2026 17:57
@jlongster jlongster merged commit a31698f into dev Jun 27, 2026
10 checks passed
@jlongster jlongster deleted the jlongster/more-tests2 branch June 27, 2026 18:10
github-actions Bot pushed a commit to iwwadigital/opencode that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant