fix(ui): make select hover feedback immediate by opencode-agent[bot] · Pull Request #34121 · anomalyco/opencode · GitHub
Skip to content

fix(ui): make select hover feedback immediate#34121

Merged
Brendonovich merged 1 commit into
devfrom
variant-hover-lag
Jun 27, 2026
Merged

fix(ui): make select hover feedback immediate#34121
Brendonovich merged 1 commit into
devfrom
variant-hover-lag

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • remove the 200 ms background/color transition from legacy select rows
  • make model variant hover feedback follow the pointer immediately
  • preserve existing highlighted, selected, and keyboard behavior

Root cause

The composer variant picker uses the shared legacy Select. Its option rows animated background-color and color for 200 ms, so the previous highlight faded out while the next faded in as the pointer moved between variants. No expensive model or composer work was occurring on hover.

Validation

  • compared the real Select Storybook story at origin/dev and this branch with identical state and pointer interactions
  • verified computed transition duration changes from 200 ms to 0 ms
  • verified pointer hover, ArrowDown highlighting, Escape dismissal/focus restoration, and pointer selection
  • bun run typecheck in packages/ui
  • bun test src --only-failures in packages/ui (4 passed)
  • bunx prettier --check packages/ui/src/components/select.css
  • git diff --check

The monorepo pre-push typecheck currently fails in unchanged packages/tui/src/context/data.tsx; the same failure reproduces on clean origin/dev. The affected packages/ui checks pass.

@opencode-agent opencode-agent Bot requested a review from Brendonovich June 26, 2026 21:44
@jayair jayair marked this pull request as ready for review June 26, 2026 21:48
@Brendonovich Brendonovich merged commit 5a55135 into dev Jun 27, 2026
10 of 11 checks passed
@Brendonovich Brendonovich deleted the variant-hover-lag branch June 27, 2026 04:47
BenGu3 pushed a commit to BenGu3/opencode that referenced this pull request Jun 27, 2026
Co-authored-by: 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 <little-frank@opencord.local>
josechifflet pushed a commit to josechifflet/opencode that referenced this pull request Jun 27, 2026
Co-authored-by: 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 <little-frank@opencord.local>
(cherry picked from commit 5a55135)
github-actions Bot pushed a commit to iwwadigital/opencode that referenced this pull request Jun 27, 2026
Co-authored-by: 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 <little-frank@opencord.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant