Fix missing TalkBack labels on Card Browser filter checkboxes by GuTS805 · Pull Request #21422 · ankidroid/Anki-Android · GitHub
Skip to content

Fix missing TalkBack labels on Card Browser filter checkboxes #21422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-allison merged 1 commit into from
Aug 7, 2026
+82 −0
Merged

Fix missing TalkBack labels on Card Browser filter checkboxes #21422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/browser/search/CardStateBottomSheetFragment.kt
View file
Open in desktop
1 change: 1 addition & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/browser/search/FlagsBottomSheetFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ class FlagsBottomSheetFragment : BottomSheetDialogFragment(R.layout.fragment_bot
) {
val model = this.states[position]
holder.binding.text.text = model.label
holder.binding.checkbox.contentDescription = model.label
holder.binding.icon.setImageResource(model.flag.drawableRes)
// TODO: Long press to rename
holder.binding.root.setOnClickListener { onItemClickedListener(model.flag) }
Expand Down
40 changes: 40 additions & 0 deletions AnkiDroid/src/test/java/com/ichi2/anki/browser/search/CardStateBottomSheetFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: 2026 Alok Srivastava <alok020505@gmail.com>

package com.ichi2.anki.browser.search

import android.os.Looper
import android.widget.CheckBox
import androidx.recyclerview.widget.RecyclerView
import androidx.test.espresso.Espresso.onView
import androidx.test.espresso.matcher.RootMatchers.isDialog
import androidx.test.espresso.matcher.ViewMatchers.withId
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.ichi2.anki.R
import com.ichi2.anki.RobolectricTest
import com.ichi2.anki.browser.withCardBrowserFragment
import org.hamcrest.MatcherAssert.assertThat
import org.hamcrest.Matchers.equalTo
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.Shadows.shadowOf

/** Test of [CardStateBottomSheetFragment] */
@RunWith(AndroidJUnit4::class)
class CardStateBottomSheetFragmentTest : RobolectricTest() {
// TalkBack users must hear which card state a checkbox toggles, not just "checked"/"not checked"
@Test
fun `card state checkbox exposes its label to TalkBack`() =
withCardBrowserFragment {
CardStateBottomSheetFragment().show(childFragmentManager, CardStateBottomSheetFragment.TAG)
shadowOf(Looper.getMainLooper()).idle()

onView(withId(R.id.list)).inRoot(isDialog()).check { view, _ ->
val recyclerView = view as RecyclerView
val holder = requireNotNull(recyclerView.findViewHolderForAdapterPosition(0))
val checkbox = holder.itemView.findViewById<CheckBox>(R.id.checkbox)
// position 0 is CardState.New
assertThat(checkbox.contentDescription, equalTo("New" as CharSequence))
}
}
}
40 changes: 40 additions & 0 deletions AnkiDroid/src/test/java/com/ichi2/anki/browser/search/FlagsBottomSheetFragmentTest.kt
View file
Open in desktop
Loading