{{ message }}
Repository navigation
Fix JSON serialization of quantities with decimal values - #868
Merged
Merged
Conversation
Owner
|
Solid work on this 👏 Love the tests! I think it is clever to use string to support How about this:
This makes the schema more extensible to other types of numbers with generics, as have been discussed a number of times: |
rohahn
force-pushed
the
decimal-serialization
branch
from
December 17, 2020 15:56
75665e8 to
c5af7a1
Compare
Contributor
Author
|
I implemented your proposal. |
Add IDecimalQuantity interface to expose the decimal value Serialize decimal values as string to keep number of decimal places
rohahn
force-pushed
the
decimal-serialization
branch
from
December 17, 2020 17:14
c5af7a1 to
e9a8161
Compare
angularsen
approved these changes
Dec 17, 2020
angularsen
left a comment
angularsen
left a comment
Owner
There was a problem hiding this comment.
Looks perfect to me, great work on this!
Owner
|
Nuget is on the way out, I'd appreciate it if you gave it a spin to ensure it works as expected and comment back here! 🙇 |
Contributor
Author
|
Why is the version number 4.3.0? |
Owner
angularsen
added a commit
that referenced
this pull request
Apr 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IDecimalQuantity interface to expose the decimal value
Serialize decimal values as string to keep number of decimal places