{{ message }}
This repository was archived by the owner on May 29, 2019. It is now read-only.
Fixes bug with backdrop click#5911
Open
no1lov3sme wants to merge 4 commits into
Open
Conversation
Fixes bug with text selection and mouse up event on modal backdrop.
Contributor
Contributor
|
The implementation should be changed to something similar to this from Bootstrap |
Contributor
|
@no1lov3sme, do you intend on fixing the issues with this PR or shall I close it? Thanks. |
Author
|
@icfantv, please specify ehat should be fixed. I've already refactored the code in my last commit; tests are passing. |
Contributor
|
@no1lov3sme, see the comment from @wesleycho. |
| var selector = 'body > div.modal'; | ||
| $document.find(selector).mousedown(); | ||
| $document.find(selector).mouseup(); | ||
| $document.find(selector).click(); |
Contributor
There was a problem hiding this comment.
This should be in a separate test - you could just copy/paste the test this is modifying, and revert the original test.
|
Any news on this? |
|
there's a line 'element.one'... is that supposed to be element.on? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug when selecting text and moving mouse away from modal container to the backdrop and releasing mouse button.