Removed the use of remove() method by kasparasg · Pull Request #1403 · angular-ui/bootstrap · GitHub
Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Removed the use of remove() method#1403

Closed
kasparasg wants to merge 34 commits into
angular-ui:bootstrap3from
x-sunsetted-Pure360:tooltip-hide-fix
Closed

Removed the use of remove() method#1403
kasparasg wants to merge 34 commits into
angular-ui:bootstrap3from
x-sunsetted-Pure360:tooltip-hide-fix

Conversation

@kasparasg

Copy link
Copy Markdown

When hiding and showing the popover the bound events were removed from the element, because of the use of remove(). That means that if you have custom popover template which has some clickable dynamic content it only works on the first show of the popover. Therefore I put in place a simple fix. Let me know if this can be merged in or if not, how would you do it differently?

Thanks a lot.

Justin Hall and others added 30 commits November 23, 2013 17:56
Closes #1240

If starting out collapsed, the expand animation would jump since the `initialAnimSkip` was still `true`.
Previously, there would be a case where the two transitions would run
as the cancel would asynchronously invoke the reject handler of the
transition which would set the currTransition to undefined even when
the currTransition has been replaced with a new transition.
@jbruni

jbruni commented Dec 17, 2013

Copy link
Copy Markdown
Contributor

@kasparasg

Copy link
Copy Markdown
Author

@jbruni thanks for the explanation, it makes sense 👍 I hope your PR gets merged in Angular core.

@chrisirhc

Copy link
Copy Markdown
Contributor

This should be fixed soon via #1455 .

@mgol

mgol commented Aug 14, 2014

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants