{{ message }}
This repository was archived by the owner on May 29, 2019. It is now read-only.
Removed the use of remove() method#1403
Closed
kasparasg wants to merge 34 commits into
Closed
Conversation
adds functionality for justifed tabs http://getbootstrap.com/components/#nav-justified
Closes #1240 If starting out collapsed, the expand animation would jump since the `initialAnimSkip` was still `true`.
Previously, there would be a case where the two transitions would run as the cancel would asynchronously invoke the reject handler of the transition which would set the currTransition to undefined even when the currTransition has been replaced with a new transition.
Badges in BS3 don't have contextual styles anymore. Closes #1290
…t were attached to the element
Contributor
This was referenced Dec 17, 2013
Author
|
@jbruni thanks for the explanation, it makes sense 👍 I hope your PR gets merged in Angular core. |
Contributor
|
This should be fixed soon via #1455 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When hiding and showing the popover the bound events were removed from the element, because of the use of
remove(). That means that if you have custom popover template which has some clickable dynamic content it only works on the first show of the popover. Therefore I put in place a simple fix. Let me know if this can be merged in or if not, how would you do it differently?Thanks a lot.