Refactor admin as a component (part of Issue 2490) by nstuyvesant · Pull Request #2492 · angular-fullstack/generator-angular-fullstack · GitHub
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/test/get-expected-files.js
4 changes: 2 additions & 2 deletions templates/app/client/app/admin(auth)/admin(html).html
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<div class="container">
<p>The delete user and user index api routes are restricted to users with the 'admin' role.</p>
<ul class="list-group user-list">
<li class="list-group-item" ng-repeat="user in admin.users">
<li class="list-group-item" ng-repeat="user in $ctrl.users">
<div class="user-info">
<strong>{{user.name}}</strong><br>
<span class="text-muted">{{user.email}}</span>
</div>
<a ng-click="admin.delete(user)" class="trash"><span class="fa fa-trash fa-2x"></span></a>
<a ng-click="$ctrl.delete(user)" class="trash"><span class="fa fa-trash fa-2x"></span></a>
</li>
</ul>
</div>
4 changes: 2 additions & 2 deletions templates/app/client/app/admin(auth)/admin(pug).pug
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
p
| The delete user and user index api routes are restricted to users with the 'admin' role.
ul.list-group
li.list-group-item(ng-repeat='user in admin.users')
li.list-group-item(ng-repeat='user in $ctrl.users')
strong {{user.name}}
br
span.text-muted {{user.email}}
a.trash(ng-click='admin.delete(user)')
a.trash(ng-click='$ctrl.delete(user)')
span.glyphicon.glyphicon-trash.pull-right
33 changes: 33 additions & 0 deletions templates/app/client/app/admin(auth)/admin.component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
'use strict';
import angular from 'angular';<% if (filters.uirouter) { %>
import uiRouter from 'angular-ui-router';<% } %>
import routes from './admin.routes';

export class AdminController {
<%_ if(filters.ts || filters.flow) { _%>
users: Object[];

<%_ } _%>
/*@ngInject*/
constructor(User) {
this.User = User;
}

$onInit() {
this.users = this.User.query(); // Fetch all users
}

delete(user) {
user.$remove();
this.users.splice(this.users.indexOf(user), 1);
}
}

export default angular.module('<%= scriptAppName %>.admin', ['<%= scriptAppName %>.auth'<% if (filters.ngroute) { %>,
'ngRoute'<% } if (filters.uirouter) { %>, uiRouter<% } %>])
.config(routes)
.component('admin', {
template: require('./admin.<%= templateExt %>'),
controller: AdminController
})
.name;
18 changes: 0 additions & 18 deletions templates/app/client/app/admin(auth)/admin.controller.js

This file was deleted.

8 changes: 2 additions & 6 deletions templates/app/client/app/admin(auth)/admin.routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ export default function routes($routeProvider) {
'ngInject';
$routeProvider
.when('/admin', {
template: require('./admin.<%= templateExt %>'),
controller: 'AdminController',
controllerAs: 'admin',
template: '<admin></admin>',
authenticate: 'admin'
});
};<% } %>
Expand All @@ -17,9 +15,7 @@ export default function routes($stateProvider) {
$stateProvider
.state('admin', {
url: '/admin',
template: require('./admin.<%= templateExt %>'),
controller: 'AdminController',
controllerAs: 'admin',
template: '<admin></admin>',
authenticate: 'admin'
});
};<% } %>
13 changes: 0 additions & 13 deletions templates/app/client/app/admin(auth)/index.js

This file was deleted.

2 changes: 1 addition & 1 deletion templates/app/client/app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {routeConfig} from './app.config';
<%_ if(filters.auth) { _%>
import _Auth from '../components/auth/auth.module';
import account from './account';
import admin from './admin';<% } %>
import admin from './admin/admin.component';<% } %>
import navbar from '../components/navbar/navbar.component';
import footer from '../components/footer/footer.component';
import main from './main/main.component';
Expand Down
12 changes: 5 additions & 7 deletions templates/app/server/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,14 @@ mongoose.Promise = require('bluebird');<% } %><% if (filters.sequelize) { %>
import sqldb from './sqldb';<% } %>
import config from './config/environment';
import http from 'http';
<% if(filters.models) { %>import seedDatabaseIfNeeded from './config/seed';<% } %>
<% if (filters.mongoose) { %>
// Connect to MongoDB
mongoose.connect(config.mongo.uri, config.mongo.options);
mongoose.connection.on('error', function(err) {
console.error('MongoDB connection error: ' + err);
process.exit(-1); // eslint-disable-line no-process-exit
});
<% } %><% if(filters.models) { %>
// Populate databases with sample data
if(config.seedDB) {
require('./config/seed');
}
<% } %>
// Setup server
var app = express();
Expand All @@ -41,12 +37,14 @@ function startServer() {
});
}
<% if(filters.sequelize) { %>
sqldb.sequelize.sync()
sqldb.sequelize.sync()<% if(filters.models) { %>
.then(seedDatabaseIfNeeded)<% } %>
.then(startServer)
.catch(function(err) {
console.log('Server failed to start due to error: %s', err);
});
<% } else { %>
<% } else { %><% if(filters.models) { %>
seedDatabaseIfNeeded();<% } %>
setImmediate(startServer);
<% } %>
// Expose app
Expand Down
125 changes: 64 additions & 61 deletions templates/app/server/config/seed(models).js