{{ message }}
This repository was archived by the owner on Oct 14, 2024. It is now read-only.
feat: update to Angular 8#679
Open
alan-agius4 wants to merge 1 commit into
Open
Conversation
The main noticeable change in the removal of `@nguniversal/module-map-ngfactory-loader`. This is because now in Angular 8 we support standard import syntax which no longer require custom logic to support lazy loading.
Example
```ts
loadChildren: () => import('./lazy/lazy.module').then(m => m.LazyModule)
```
instead of
```ts
loadChildren: './lazy/lazy.module#LazyModule'
```
alan-agius4
force-pushed
the
update-version-8
branch
from
01d9b0e to
d4e4241
Compare
alan-agius4
commented
Jun 4, 2019
Contributor
Author
There was a problem hiding this comment.
We should always optimize components css in server builds.
Contributor
Author
|
//cc @CaerusKaru |
Contributor
Author
|
We should also probably update the schematics not to add this dependency |
Contributor
|
Hi - We are already making few other changes to the schematic to make this work. Can you refer to vikerman/v8-lazy@515239b for other changes required to make this work - Essentially moving all dependencies to @angular and @nguniversal out of server.ts in to main.ts. This is required for dynamic imports to properly work on the server or it would fail due to Angular being bundled as two copies in server.ts bundle and main.ts bundle.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main noticeable change in the removal of
@nguniversal/module-map-ngfactory-loader. This is because now in Angular 8 we support standard import syntax which no longer require custom logic to support lazy loading.Example
instead of
loadChildren: './lazy/lazy.module#LazyModule'