You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fix the issue issue 1210 in which autofilled property is not mentioned in the document along with this added another missing property documentation. Please let me know if any changes are require.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Thanks for the PR! I am happy to see the description of what would happen if the property autofilled is set to true or false.
However, I think there's still room for improvement in the following sentence:
This property allows us to specify Whether the input is currently in an autofilled state.
First, the word "Whether" should be lower-case.
Second, and most important - I still don't understand what would be the situation when a developer should set the autofilled property to true or false. Is it referring to the browser's autofill functionality? In that case, how can develop identify if the control was autofilled? Or is this referring to something else? A description of a concrete situation when this property should be set would be helpful.
Hi @DmitryEfimenko I will fix the word.
As per my understanding this is similar to the case where we mark a control touched/disabled. Similarly we need to implement this flag with true or false when the property is auto filled by the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the issue issue 1210 in which autofilled property is not mentioned in the document along with this added another missing property documentation. Please let me know if any changes are require.
After fix document screenshot.
