fix issue #1210 in material.angular.io https://github.com/angular/ma… by darpankumar · Pull Request #22 · angular/material2-docs-content · GitHub
Skip to content

fix issue #1210 in material.angular.io https://github.com/angular/ma…#22

Open
darpankumar wants to merge 1 commit into
angular:mainfrom
darpankumar:main
Open

fix issue #1210 in material.angular.io https://github.com/angular/ma…#22
darpankumar wants to merge 1 commit into
angular:mainfrom
darpankumar:main

Conversation

@darpankumar

Copy link
Copy Markdown

This PR fix the issue issue 1210 in which autofilled property is not mentioned in the document along with this added another missing property documentation. Please let me know if any changes are require.

After fix document screenshot.
angular-doc

@google-cla

google-cla Bot commented Nov 14, 2023

Copy link
Copy Markdown

@darpankumar darpankumar reopened this Nov 14, 2023
@DmitryEfimenko

Copy link
Copy Markdown

Thanks for the PR! I am happy to see the description of what would happen if the property autofilled is set to true or false.
However, I think there's still room for improvement in the following sentence:

This property allows us to specify Whether the input is currently in an autofilled state.

First, the word "Whether" should be lower-case.
Second, and most important - I still don't understand what would be the situation when a developer should set the autofilled property to true or false. Is it referring to the browser's autofill functionality? In that case, how can develop identify if the control was autofilled? Or is this referring to something else? A description of a concrete situation when this property should be set would be helpful.

@darpankumar

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants