feat(google-maps): Add support for the gmp-click event by jermowery · Pull Request #33147 · angular/components · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion goldens/google-maps/index.api.md
10 changes: 10 additions & 0 deletions src/google-maps/map-advanced-marker/map-advanced-marker.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ describe('MapAdvancedMarker', () => {
title: undefined,
content: undefined,
gmpDraggable: undefined,
gmpClickable: undefined,
zIndex: undefined,
map: mapSpy,
});
Expand All @@ -46,6 +47,7 @@ describe('MapAdvancedMarker', () => {
map: mapSpy,
content: undefined,
gmpDraggable: true,
gmpClickable: true,
zIndex: 1,
};
const advancedMarkerSpy = createAdvancedMarkerSpy(options);
Expand All @@ -56,6 +58,7 @@ describe('MapAdvancedMarker', () => {
fixture.componentInstance.title = options.title!;
fixture.componentInstance.content = options.content!;
fixture.componentInstance.gmpDraggable = options.gmpDraggable!;
fixture.componentInstance.gmpClickable = options.gmpClickable!;
fixture.componentInstance.zIndex = options.zIndex!;

fixture.detectChanges();
Expand All @@ -69,6 +72,7 @@ describe('MapAdvancedMarker', () => {
title: 'marker title',
content: undefined,
gmpDraggable: true,
gmpClickable: true,
zIndex: 1,
};
const advancedMarkerSpy = createAdvancedMarkerSpy(options);
Expand All @@ -87,6 +91,7 @@ describe('MapAdvancedMarker', () => {
title: 'marker title',
content: undefined,
gmpDraggable: true,
gmpClickable: true,
zIndex: 1,
};

Expand All @@ -95,6 +100,7 @@ describe('MapAdvancedMarker', () => {
title: 'marker title 2',
content: undefined,
gmpDraggable: false,
gmpClickable: false,
zIndex: 999,
map: mapSpy,
};
Expand All @@ -106,6 +112,7 @@ describe('MapAdvancedMarker', () => {
fixture.componentInstance.title = expectedOptions.title!;
fixture.componentInstance.content = expectedOptions.content!;
fixture.componentInstance.gmpDraggable = expectedOptions.gmpDraggable!;
fixture.componentInstance.gmpClickable = expectedOptions.gmpClickable!;
fixture.componentInstance.zIndex = expectedOptions.zIndex!;
fixture.componentInstance.options = options!;

Expand All @@ -132,6 +139,7 @@ describe('MapAdvancedMarker', () => {
expect(customSpy).not.toHaveBeenCalledWith('drag', jasmine.any(Function));
expect(customSpy).not.toHaveBeenCalledWith('dragend', jasmine.any(Function));
expect(customSpy).not.toHaveBeenCalledWith('dragstart', jasmine.any(Function));
expect(customSpy).not.toHaveBeenCalledWith('gmp-click', jasmine.any(Function));
});

it('should be able to add an event listener after init', () => {
Expand Down Expand Up @@ -162,6 +170,7 @@ describe('MapAdvancedMarker', () => {
[position]="position"
[content]="content"
[gmpDraggable]="gmpDraggable"
[gmpClickable]="gmpClickable"
[zIndex]="zIndex"
(mapClick)="handleClick()"
(mapDblclick)="handleDblclick()"
Expand All @@ -181,6 +190,7 @@ class TestApp {
position!: google.maps.LatLng | google.maps.LatLngLiteral;
content!: Node | google.maps.marker.PinElement;
gmpDraggable!: boolean;
gmpClickable!: boolean;
zIndex!: number;
options!: google.maps.marker.AdvancedMarkerElementOptions;

Expand Down
27 changes: 26 additions & 1 deletion src/google-maps/map-advanced-marker/map-advanced-marker.ts
Loading