fix(@angular/build): always disable JSON stats with dev-server by clydin · Pull Request #29707 · angular/angular-cli · GitHub
Skip to content

fix(@angular/build): always disable JSON stats with dev-server - #29707

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:dev/disable-stats-json
Feb 25, 2025
Merged

clydin merged 1 commit into
angular:mainfrom
clydin:dev/disable-stats-json

Conversation

@clydin

@clydin clydin commented Feb 25, 2025

Copy link
Copy Markdown
Member

When using the development server, the statsJson option will now unconditionally be disabled. The output JSON file is not accessible with the server and the analysis/generation of the JSON file may increase the rebuild time. Additionally, the JSON file changes during a rebuild may unexpectedly cause component HMR fallback to a full reload due to non-component file changes in the build output.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Feb 25, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 25, 2025
@clydin
clydin requested a review from dgp1130 February 25, 2025 16:15
Comment thread packages/angular/build/src/builders/dev-server/vite-server.ts
When using the development server, the `statsJson` option will now
unconditionally be disabled. The output JSON file is not accessible
with the server and the analysis/generation of the JSON file may
increase the rebuild time. Additionally, the JSON file changes during
a rebuild may unexpectedly cause component HMR fallback to a full
reload due to non-component file changes in the build output.
@clydin
clydin force-pushed the dev/disable-stats-json branch from fb14c14 to 055d972 Compare February 25, 2025 17:54
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 25, 2025
@clydin
clydin merged commit eb058d0 into angular:main Feb 25, 2025
@clydin

clydin commented Feb 25, 2025

Copy link
Copy Markdown
Member Author

@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants