{{ message }}
feat(@angular/ssr): add modulepreload for lazy-loaded routes - #28919
Merged
Conversation
alan-agius4
added
action: review
angular-robot
Bot
added
detected: feature
alan-agius4
force-pushed
the
preload-ssr
branch
2 times, most recently
from
November 21, 2024 11:40
95f2b19 to
9b4c01a
Compare
eneajaho
reviewed
Nov 21, 2024
alan-agius4
force-pushed
the
preload-ssr
branch
5 times, most recently
from
November 22, 2024 10:22
913f62e to
1eb3c20
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
AndrewKushnir
approved these changes
Nov 25, 2024
Collaborator
Author
alan-agius4
force-pushed
the
preload-ssr
branch
3 times, most recently
from
November 29, 2024 10:10
2db94b8 to
84c0543
Compare
alan-agius4
force-pushed
the
preload-ssr
branch
8 times, most recently
from
December 2, 2024 14:42
212ad1a to
d78d2ad
Compare
clydin
approved these changes
Dec 3, 2024
alan-agius4
force-pushed
the
preload-ssr
branch
7 times, most recently
from
December 4, 2024 14:40
509feb7 to
b15ae1f
Compare
dgp1130
reviewed
Dec 5, 2024
alan-agius4
force-pushed
the
preload-ssr
branch
from
December 6, 2024 09:10
b15ae1f to
4281f58
Compare
dgp1130
reviewed
Dec 7, 2024
dgp1130
left a comment
dgp1130
left a comment
Collaborator
There was a problem hiding this comment.
Just responding to some comment threads, I'll take another look at the code on Monday.
alan-agius4
force-pushed
the
preload-ssr
branch
from
December 8, 2024 12:55
4281f58 to
572c1a0
Compare
dgp1130
approved these changes
Dec 9, 2024
dgp1130
left a comment
dgp1130
left a comment
Collaborator
There was a problem hiding this comment.
No major concerns on my end. I'm on board with an initial implementation like this and we can work through any edge cases or deoptimizations as they come.
I kind of suspect we'll want to expand the transform to apply to any dynamic import inside a loadComponent / loadChildren function, but I'm happy to keep this constrained for now and expand it later.
Enhance performance when using SSR by adding `modulepreload` links to lazy-loaded routes. This ensures that the required modules are preloaded in the background, improving the user experience and reducing the time to interactive. Closes angular#26484
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
preload-ssr
branch
from
December 10, 2024 11:00
572c1a0 to
31ff83a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance performance when using SSR by adding
modulepreloadlinks to lazy-loaded routes. This ensures that the required modules are preloaded in the background, improving the user experience and reducing the time to interactive.Closes #26484