{{ message }}
fix(@angular/cli): skip downloading temp CLI when running ng update without package names#24028
Merged
Merged
Conversation
alan-agius4
added
action: review
alan-agius4
removed
the
action: review
… without package names In the case when `ng update` is ran without a package name, an update is not be performed. In this case using the current installed version of the CLI is good enough. Closes angular#24024
alan-agius4
force-pushed
the
update-temp-cli-no-packages
branch
from
380ac42 to
d26fe37
Compare
alan-agius4
commented
Oct 6, 2022
Collaborator
Author
There was a problem hiding this comment.
Not sure why this was here @clydin maybe you remember? This needs to be removed as otherwise certain errors are not fatal. Example: https://app.circleci.com/pipelines/github/angular/angular-cli/26850/workflows/10782a5e-36c3-4de6-ae85-0ebcfe456e4e/jobs/356140/parallel-runs/0/steps/0-105
The test previously failed because when trying to download the temp version of the CLI. This check is bypassed since pacote is not used.
Member
There was a problem hiding this comment.
May have been leftover from before the package names were validated to be registry names.
alan-agius4
added
the
action: review
clydin
approved these changes
Oct 6, 2022
alan-agius4
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case when
ng updateis ran without a package name, an update is not be performed. In this case using the current installed version of the CLI is good enough.Closes #24024