{{ message }}
fix(docs-infra): keep an explicit theme choice when the OS scheme changes - #70588
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): keep an explicit theme choice when the OS scheme changes#70588erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…nges `watchPreferredColorScheme` applied the OS scheme unconditionally, while `setTheme`, `loadThemePreference` and the bootstrap script in index.html all only follow it for `auto`. Choosing Light and then letting the OS switch to dark repainted the site dark while the theme menu still reported Light, until a reload restored it.
angular-robot
Bot
added
the
area: docs-infra
alan-agius4
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-09-06.at.13.13.41.mov
Steps to reproduce
Expected: the site stays dark, since Dark was chosen explicitly.
Actual: the site turns light, and the theme menu still shows the checkmark on Dark.
Confirm in the console:
Reloading restores Dark, until the OS changes again. Anyone using macOS Auto appearance hits this unprompted at sunrise and sunset.
After:
Screen.Recording.2026-09-06.at.13.16.13.mov