{{ message }}
test(docs-infra): run the orphaned shared-docs pipes specs - #70585
Open
erkamyaman wants to merge 1 commit into
Open
test(docs-infra): run the orphaned shared-docs pipes specs#70585erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
`relative-link.pipe.spec.ts` and `is-active-navigation-item.pipe.spec.ts` arrived with this package's BUILD file in angular#57132, but no test target came with them and `lib` excludes `**/*.spec.ts`, so nothing has ever compiled them. `bazel query` reports both as not declared in the package. They pass unmodified. `getRelativeUrl` has no other coverage in the repo, and both pipes are used by the search dialog, the navigation list and the not found page.
angular-robot
Bot
added
the
area: docs-infra
JeanMeche
approved these changes
Sep 5, 2026
JeanMeche
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relative-link.pipe.spec.tsandis-active-navigation-item.pipe.spec.tsarrived with this package's BUILD file in #57132, but no test target came with them andlibexcludes**/*.spec.ts, so nothing has ever compiled them.bazel queryreports both as not declared in the package.They pass unmodified.
getRelativeUrlhas no other coverage in the repo, and both pipes are used by the search dialog, the navigation list and the not found page.