{{ message }}
fix(core): defer afterRenderEffect sequences registered while hooks run - #70581
Open
arturovt wants to merge 1 commit into
Open
fix(core): defer afterRenderEffect sequences registered while hooks run#70581arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
`AfterRenderImpl.addSequence` added the sequence straight to `sequences` without checking whether hooks were already running. If a view was change-detected from inside a render hook (for example, when a custom element connects to the DOM during a render phase), its `afterRenderEffect` sequence could be added mid-pass. The phase loop would then run its later phases in the current pass and skip the earlier ones, so `earlyRead` could run a tick after `write`. This also shifted the phase callback arguments and eventually caused `TypeError: fn is not a function` when the view was destroyed. Defer these registrations to the next pass, like `register` already does for sequences registered outside a view. Fixes angular#61715
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

AfterRenderImpl.addSequenceadded the sequence straight tosequenceswithout checking whether hooks were already running. If a view was change-detected from inside a render hook (for example, when a custom element connects to the DOM during a render phase), itsafterRenderEffectsequence could be added mid-pass. The phase loop would then run its later phases in the current pass and skip the earlier ones, soearlyReadcould run a tick afterwrite. This also shifted the phase callback arguments and eventually causedTypeError: fn is not a functionwhen the view was destroyed.Defer these registrations to the next pass, like
registeralready does for sequences registered outside a view.Fixes #61715