{{ message }}
refactor(core): expose host ref in DirectiveFixture - #70578
Open
crisbeto wants to merge 1 commit into
Open
Conversation
crisbeto
added
action: review
Exposes the host component ref in the `DirectiveFixture` so consumers can access things like `onDestroy`. This is something we need for test harnesses in the CDK.
JeanMeche
reviewed
Sep 5, 2026
Member
There was a problem hiding this comment.
Isn't it a bit weird that we get a ComponentRef in a DirectiveFixture ? There might not be a component at all (when applied on a regular element)
Member
Author
There was a problem hiding this comment.
Yeah it's the reason why I didn't get expose it initially. Another option can be to just expose onDestroy.
JeanMeche
reviewed
Sep 5, 2026
Member
There was a problem hiding this comment.
Should we maybe add some tests around hostRef ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the host component ref in the
DirectiveFixtureso consumers can access things likeonDestroy. This is something we need for test harnesses in the CDK.