{{ message }}
fix(docs-infra): don't render a return type on constructor signatures - #70577
Open
MeAkib wants to merge 1 commit into
Open
fix(docs-infra): don't render a return type on constructor signatures#70577MeAkib wants to merge 1 commit into
MeAkib wants to merge 1 commit into
Conversation
The API reference code block built every class member signature with a
return type, so constructors were rendered as invalid TypeScript:
class ActivationStart {
constructor(snapshot: ActivatedRouteSnapshot): ActivationStart;
}
Constructors are extracted as regular method entries whose return type is
the class itself, so `getMethodCodeLine` now omits the return type when
the member is a constructor, for both the single signature and the
overloaded cases:
class ActivationStart {
constructor(snapshot: ActivatedRouteSnapshot);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The API reference code block built every class member signature with a return type, so constructors were rendered as invalid TypeScript:
Constructors are extracted as regular method entries whose return type is the class itself, so
getMethodCodeLinenow omits the return type when the member is a constructor, for both the single signature and the overloaded cases:What is the current behavior?
https://angular.dev/api/router/ActivationStart