{{ message }}
test(devtools): run the orphaned app component spec - #70572
Open
erkamyaman wants to merge 1 commit into
Open
Conversation
`app.component.spec.ts` has been in the tree since the initial DevTools commit in 2020, but no revision of `shell-browser/src/app/BUILD.bazel` has ever listed it, and that file has no globs. Two of the three specs in the directory are wired up; this one has never run. It could not run as written. The setup declared `AppComponent` and imported `RouterModule.forRoot([])`, neither of which applies now that the component is standalone and injects `MessageBus` and `DEEP_LINK_INSTANCE_ID`. It now stubs the `chrome.devtools` surface that `ngOnInit` reads and covers both lifecycle hooks: the listeners registered on init, the two performance track emits, the three guards on the deep link listener, and the listeners removed on destroy. Follow-up to angular#70570, which fixed the same problem in ng-devtools-backend.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app.component.spec.tshas been in the tree since the initial DevTools commit in 2020, but no revision ofshell-browser/src/app/BUILD.bazelhas ever listed it, and that file has no globs. Two of the three specs in the directory are wired up; this one has never run.It could not run as written. The setup declared
AppComponentand importedRouterModule.forRoot([]), neither of which applies now that the component is standalone and injectsMessageBusandDEEP_LINK_INSTANCE_ID.It now stubs the
chrome.devtoolssurface thatngOnInitreads and covers both lifecycle hooks: the listeners registered on init, the two performance track emits, the three guards on the deep link listener, and the listeners removed on destroy.Follow-up to #70570, which fixed the same problem in ng-devtools-backend.