{{ message }}
refactor(devtools): revamp highlighter#69517
Draft
hawkgs wants to merge 1 commit into
Draft
Conversation
Revamp the highlighter by introducing a completely new mechanism. - Introduce a `Highlight` class that stores the required element references and provides control over the highlight instances. - Introduce highlight templates for each highlight type. - Decouple non-inspection related highlights from `component-inspector`. - Create a weakly-referened storing mechanism where the target element serves as a key. The highlight is disposed when the target is removed from the DOM. - Add a priority mechanism where only the highest priority highlight of a target element is rendered. - Add sizing functionality (needed for static highlights like the hydration ones). - Add support for multiple labels per highlight. - Unhighlight all elements when the DevTools are closed (bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Revamp the highlighter by introducing a completely new mechanism.
Highlightclass that stores the required element references and provides control over the highlight instances.component-inspector.