A similar change was done for UMD bundles already in 4a41442, this PR fixes things for SystemJS bundles.

LGTM

What's the severity? Do we need a beta.3?

Where is the missing testing for this? Don't we test the example tests using the bundle?

What's the severity? Do we need a beta.3?

This pretty much breaks unit tests for all the people using SystemJS bundles.
IMO definitively needed for beta.3

Where is the missing testing for this? Don't we test the example tests using the bundle?

I was also surprised that we don't have tests for this. From what I understand now we use other bundles for e2e tests but we don't use the testing bundles anywhere.

We should add proper testing as a follow up of this PR.

Thanks for the PR, I was hitting the wall for ng-bootstrap tests until @pkozlowski-opensource told me that it was missing :P

Thanks for finding this - sorry I didn't realize the bundles would need fixing when I made the test setup changes.

Thanks for finding this - sorry I didn't realize the bundles would need fixing when I made the test setup changes.

@juliemr no worries - there should be safety net for this. In the future we should:

• add automated tests
• think of a way of sharing this config for all bundles

Please bring up the beta.3 question on slack so we get a definitive answer. Would be nice if we could just publish an updated beta.2 bundle and not change any code? caretaker takes a lot of time without extra releases to perform

I decided to just cherry-pick this change onto the 2.0.0-beta.2 branch and re-publish the bundles.
Please verify: https://code.angularjs.org/2.0.0-beta.2/

I can see it. Thank you.

For npm users, should we wait for beta.3?

I am not sure the severity for the use case of getting bundles out of the npm distribution. The workaround of replacing files from the CDN seems possible. @mhevery ?

For the ones that relies on npm that won't work. A workaround can be done tho.

Personally for ng-bootstrap is not a big deal, we can wait for beta.3 while we code it up :)

The beta releases could benefit by having patch releases. Then everyone can simply run npm upgrade to take advantage of semver. Doing so everyone can simply specify that patches are fine to install with the tilde symbol (~2.0.0-beta.3.0) then the ngTeam can release patches any time for that version (~2.0.0-beta.3.1)

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}