fix(benchpress): Ensure future-proof correct initialization order for JsonFileReporter by trevorade · Pull Request #60025 · angular/angular · GitHub
Skip to content

fix(benchpress): Ensure future-proof correct initialization order for JsonFileReporter - #60025

Closed
trevorade wants to merge 1 commit into
angular:mainfrom
trevorade:patch-1
Closed

trevorade wants to merge 1 commit into
angular:mainfrom
trevorade:patch-1

Conversation

@trevorade

@trevorade trevorade commented Feb 19, 2025 •

Copy link
Copy Markdown
Contributor

Future changes to initialization order can cause this previously OK code to start having compiler erroring like: TS2729: Property 'foo' is used before its initialization.

PR Checklist

Please check if your PR fulfills the following requirements:

Not relevant for missing items.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

If you enable tsc --target=ES2022and--useDefineForClassFields, will result in a TS2729` compilation error.

Issue Number: N/A

What is the new behavior?

No compilation error with the previous flags.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from thePunderWoman February 19, 2025 21:51

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker area: benchpress target: patch This PR is targeted for the next patch release labels Feb 19, 2025
@ngbot ngbot Bot modified the milestone: Backlog Feb 19, 2025
Future changes to initialization order can cause this previously OK code to start having compiler erroring like: `TS2729: Property 'foo' is used before its initialization.`
@kirjs

kirjs commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

kirjs pushed a commit that referenced this pull request Feb 20, 2025
…0025)

Future changes to initialization order can cause this previously OK code to start having compiler erroring like: `TS2729: Property 'foo' is used before its initialization.`

PR Close #60025
@kirjs kirjs closed this in 7a8e8f3 Feb 20, 2025
kirjs pushed a commit that referenced this pull request Feb 20, 2025
…0025)

Future changes to initialization order can cause this previously OK code to start having compiler erroring like: `TS2729: Property 'foo' is used before its initialization.`

PR Close #60025
@trevorade
trevorade deleted the patch-1 branch February 20, 2025 16:56
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: benchpress target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants