{{ message }}
feat(test): allow tests to specify the platform and application#5937
Closed
juliemr wants to merge 2 commits into
Closed
feat(test): allow tests to specify the platform and application#5937juliemr wants to merge 2 commits into
juliemr wants to merge 2 commits into
Conversation
Before, all test framework wrappers (internal for dart and js/ts, angular2_test for dart and testing for js/ts) had similar logic to keep track of current global test injector and test provider list. This change wraps that logic into one class managed by the test injector.
juliemr
added
state: WIP
area: testing
Member
Member
Author
|
@pkozlowski-opensource agreed, looking into them. Dart is unhappy about const stuff. |
… providers used Part I - clean up and make the TestInjector object allow changes.
juliemr
force-pushed
the
test-with-bundles-2
branch
from
b9092d0 to
5e5f534
Compare
Member
Author
|
Status update: I was hoping to add |
Member
Author
|
New proposal is here: #5975 Closing this one for now, since it's insufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is on top of #5920