{{ message }}
Repository navigation
fix(compiler-cli): preserve defer block dependencies during HMR when class metadata is disabled - #59313
Closed
crisbeto wants to merge 1 commit into
Closed
fix(compiler-cli): preserve defer block dependencies during HMR when class metadata is disabled#59313crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
…class metadata is disabled Fixes that the compiler wasn't capturing defer block dependencies correctly when `supportTestBed` is disabled. We had tests for this, but we didn't notice the issue because the dependencies ended up being captured because of the `setClassMetadata` calls. Once they're disabled, the dependencies stopped being recorded. Fixes angular#59310.
crisbeto
added
action: review
AndrewKushnir
approved these changes
Dec 27, 2024
AndrewKushnir
removed
the
action: review
thePunderWoman
added
the
area: compiler
Contributor
thePunderWoman
pushed a commit
that referenced
this pull request
Jan 6, 2025
…class metadata is disabled (#59313) Fixes that the compiler wasn't capturing defer block dependencies correctly when `supportTestBed` is disabled. We had tests for this, but we didn't notice the issue because the dependencies ended up being captured because of the `setClassMetadata` calls. Once they're disabled, the dependencies stopped being recorded. Fixes #59310. PR Close #59313
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…class metadata is disabled (angular#59313) Fixes that the compiler wasn't capturing defer block dependencies correctly when `supportTestBed` is disabled. We had tests for this, but we didn't notice the issue because the dependencies ended up being captured because of the `setClassMetadata` calls. Once they're disabled, the dependencies stopped being recorded. Fixes angular#59310. PR Close angular#59313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the compiler wasn't capturing defer block dependencies correctly when
supportTestBedis disabled. We had tests for this, but we didn't notice the issue because the dependencies ended up being captured because of thesetClassMetadatacalls. Once they're disabled, the dependencies stopped being recorded.Fixes #59310.