{{ message }}
Language service fixes#58719
Closed
crisbeto wants to merge 2 commits into
Closed
Conversation
Currently the code fixes won't run if the template information can't be resolved on the diagnostic node. This is incorrect for diagnostics that are reported within `.ts` files. These changes make the `templateInfo` nullable and leave the early exit up to the individual fixes.
Fixes that `getCodeActions` wasn't implemented for the unused imports fixer which meant that it wouldn't show up in the most common cases.
crisbeto
added
action: review
angular-robot
Bot
added
the
area: language-service
crisbeto
commented
Nov 18, 2024
Member
Author
There was a problem hiding this comment.
Note the typo here was spawn.length instead of tc.span.length which meant that the assertion was always incorrect. I've fixed it plus a handful of tests that weren't asserting properly.
devversion
approved these changes
Nov 18, 2024
clydin
approved these changes
Nov 18, 2024
clydin
left a comment
clydin
left a comment
Member
There was a problem hiding this comment.
LGTM.
As followup, would it be useful to have some sort of requiresTemplateInfo boolean on the code fix action definition? As we increase the amount of code fixes, this would allow bypassing the getCodeActions call completely instead of adding null checks to each action. And it avoids the empty array creation plus spread/push for each.
crisbeto
added
action: merge
devversion
added
target: patch
Contributor
|
This PR was merged into the repository by commit dcd27d7. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2024
Fixes that `getCodeActions` wasn't implemented for the unused imports fixer which meant that it wouldn't show up in the most common cases. PR Close #58719
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2024
Currently the code fixes won't run if the template information can't be resolved on the diagnostic node. This is incorrect for diagnostics that are reported within `.ts` files. These changes make the `templateInfo` nullable and leave the early exit up to the individual fixes. PR Close #58719
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2024
Fixes that `getCodeActions` wasn't implemented for the unused imports fixer which meant that it wouldn't show up in the most common cases. PR Close #58719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following fixes for the language service:
fix(language-service): allow fixes to run without template info
Currently the code fixes won't run if the template information can't be resolved on the diagnostic node. This is incorrect for diagnostics that are reported within
.tsfiles. These changes make thetemplateInfonullable and leave the early exit up to the individual fixes.fix(language-service): add fix for individual unused imports
Fixes that
getCodeActionswasn't implemented for the unused imports fixer which meant that it wouldn't show up in the most common cases.