docs: move all bazel testing info to a single location - #46084
dario-piotrowicz wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
I think that bazel is not necessary
actually the script seem to use bazelisk (I guess they are the same-ish?):
There was a problem hiding this comment.
I don't think that explaining why bazel is used adds much here 🤔
There was a problem hiding this comment.
Honestly I have never run locally all the tests, on my (dinosaur) machine it would take ages, so I think it could be valuable to suggest to do that, but provide the alternative to rely on the CI
There was a problem hiding this comment.
Technically if you run everything once locally, you would get the same caching benefits as CI, but in practice this is obviously still slower. Just want to avoid recommend to rely fully on CI. Ideally folks would run some tests for the parts they have changed. e.g. if I change the compiler, I run tests in the compiler/test Bazel package.
There was a problem hiding this comment.
Yeah the first run is definitely my issue, after that the tests do run rather quick 🙂
anyways I hope that the wording here is fine then, sort of letting developers know that CI checks will be performed but not actively recommending to rely solely on that 🙂
dario-piotrowicz
changed the title
dario-piotrowicz
changed the title
There was a problem hiding this comment.
Technically if you run everything once locally, you would get the same caching benefits as CI, but in practice this is obviously still slower. Just want to avoid recommend to rely fully on CI. Ideally folks would run some tests for the parts they have changed. e.g. if I change the compiler, I run tests in the compiler/test Bazel package.
instead of presenting the same (or similar information) in both the DEVELOPER.md and the BAZEL.md files, more all the information in the BAZEL file and refer to that section in the DEVELOPER file
67ad7b9 to
d374fdf
Compare
AndrewKushnir
added
action: merge
|
Merge-assistance: the |
AndrewKushnir
added
the
merge: caretaker note
|
This PR was merged into the repository by commit f04a8ea. |
instead of presenting the same (or similar information) in both the DEVELOPER.md and the BAZEL.md files, more all the information in the BAZEL file and refer to that section in the DEVELOPER file PR Close #46084
instead of presenting the same (or similar information) in both the DEVELOPER.md and the BAZEL.md files, more all the information in the BAZEL file and refer to that section in the DEVELOPER file PR Close #46084
4 participants
instead of presenting the same (or similar information) in both the
DEVELOPER.md and the BAZEL.md files, more all the information in the
BAZEL file and refer to that section in the DEVELOPER file
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
Issue Number: N/A
Does this PR introduce a breaking change?
Other information
...in the DEVELOPER one, which seemed quite valuable for the BAZEL file as well, instead of copy that section I just figured that the DEVELOPER's md should just point to the BAZEL one and that one should be the only point of reference (as it also contains various information for debugging)