{{ message }}
ci: re-enable components repo unit tests job - #44832
Closed
devversion wants to merge 2 commits into
Closed
devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
devversion
marked this pull request as ready for review
January 26, 2022 13:14
devversion
added
action: review
Re-enables the components-repo unit tests job that we previously disabled due to the devmode target change that caused conflicts with `angular/components` patching `ng_module.bzl` of `@angular/bazel`.
To speed up the components CI job (avoiding it being a bottleneck in FW), we will stop building everything in `src/...`, but rather only build targets which are needed to run all tests within `src/...`. This notably should avoid unnecessary NPM package building. Arguably that part would also be valuable to have, but we already test the `ng_package` rule in FW itself, plus we run snapshot tests in the components repo as well.
josephperrott
force-pushed
the
ci/re-enable-components-ci-job
branch
from
January 26, 2022 22:42
a854002 to
7f8afc9
Compare
devversion
added
action: merge
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 27, 2022
To speed up the components CI job (avoiding it being a bottleneck in FW), we will stop building everything in `src/...`, but rather only build targets which are needed to run all tests within `src/...`. This notably should avoid unnecessary NPM package building. Arguably that part would also be valuable to have, but we already test the `ng_package` rule in FW itself, plus we run snapshot tests in the components repo as well. PR Close #44832
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 27, 2022
Re-enables the components-repo unit tests job that we previously disabled due to the devmode target change that caused conflicts with `angular/components` patching `ng_module.bzl` of `@angular/bazel`. PR Close #44832
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 27, 2022
To speed up the components CI job (avoiding it being a bottleneck in FW), we will stop building everything in `src/...`, but rather only build targets which are needed to run all tests within `src/...`. This notably should avoid unnecessary NPM package building. Arguably that part would also be valuable to have, but we already test the `ng_package` rule in FW itself, plus we run snapshot tests in the components repo as well. PR Close #44832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the components-repo unit tests job that we previously
disabled due to the devmode target change that caused conflicts
with
angular/componentspatchingng_module.bzlof@angular/bazel.