build: update to latest "yargs" package by petebacondarwin · Pull Request #39749 · angular/angular · GitHub
Skip to content

build: update to latest "yargs" package - #39749

Closed
petebacondarwin wants to merge 1 commit into
angular:masterfrom
petebacondarwin:update-yargs
Closed

petebacondarwin wants to merge 1 commit into
angular:masterfrom
petebacondarwin:update-yargs

Conversation

@petebacondarwin

Copy link
Copy Markdown
Contributor

The 15.x versions of yargs relied upon a version of y18n that
has a SNYK vulnerability.
This commit updates the overall project, and therefore also the
localize and compiler-cli packages to use the latest version
of yargs that does not depend upon the vulnerable y18n
version.
The AIO project was already on the latest yargs version and so
does not need upgrading.

Fixes #39743

The 15.x versions of `yargs` relied upon a version of `y18n` that
has a SNYK vulnerability.
This commit updates the overall project, and therefore also the
`localize` and `compiler-cli` packages to use the latest version
of `yargs` that does not depend upon the vulnerable `y18n`
version.
The AIO project was already on the latest `yargs` version and so
does not need upgrading.

Fixes angular#39743
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup area: i18n Issues related to localization and internationalization area: security Issues related to built-in security features, such as HTML sanitation target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Nov 18, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Nov 18, 2020
@google-cla google-cla Bot added the cla: yes label Nov 18, 2020
@petebacondarwin petebacondarwin added the security Issues that generally impact framework or application security label Nov 18, 2020
@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @petebacondarwin 👍

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 18, 2020
AndrewKushnir pushed a commit that referenced this pull request Nov 19, 2020
The 15.x versions of `yargs` relied upon a version of `y18n` that
has a SNYK vulnerability.
This commit updates the overall project, and therefore also the
`localize` and `compiler-cli` packages to use the latest version
of `yargs` that does not depend upon the vulnerable `y18n`
version.
The AIO project was already on the latest `yargs` version and so
does not need upgrading.

Fixes #39743

PR Close #39749
@petebacondarwin
petebacondarwin deleted the update-yargs branch November 19, 2020 08:35
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 20, 2020
@pullapprove pullapprove Bot added area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) and removed area: security Issues related to built-in security features, such as HTML sanitation labels Dec 20, 2020
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) area: i18n Issues related to localization and internationalization cla: yes refactoring Issue that involves refactoring or code-cleanup security Issues that generally impact framework or application security target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Synk Vulnerability SNYK-JS-Y18N-1021887 transitively in @angular/localize

3 participants